Modified GPU command signature hash to use a binary representation.

gpu/command_buffer/service/renderbuffer_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/renderbuffer_manager.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/strings/stringprintf.h"
 #include "gpu/command_buffer/common/gles2_cmd_utils.h"
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
@@ skipping 30 matching lines @@
 size_t Renderbuffer::EstimatedSize() {
   uint32 size = 0;
   manager_->ComputeEstimatedRenderbufferSize(
       width_, height_, samples_, internal_format_, &size);
   return size;
 }
 
 void Renderbuffer::AddToSignature(
     std::string* signature) const {
   DCHECK(signature);
-  *signature += base::StringPrintf(
-      "|Renderbuffer|internal_format=%04x|samples=%d|width=%d|height=%d",
-      internal_format_, samples_, width_, height_);
+  signature->append("|Renderbuffer|");
+  signature->append(reinterpret_cast<const char*>(&internal_format_),
+                    sizeof(internal_format_));
+  signature->append(reinterpret_cast<const char*>(&samples_), sizeof(samples_));
+  signature->append(reinterpret_cast<const char*>(&width_), sizeof(width_));
+  signature->append(reinterpret_cast<const char*>(&height_), sizeof(height_));

[vmiura, 2014/09/23 20:26:47]

Could this be improved by packing the values in a struct, then appending to the
signature in one go?  Or if the values were already in a struct ready to append?

[David Yen, 2014/09/23 20:45:24]

I'll create a structure to do this.

 }
 
 Renderbuffer::Renderbuffer(RenderbufferManager* manager,
                            GLuint client_id,
                            GLuint service_id)
     : manager_(manager),
       client_id_(client_id),
       service_id_(service_id),
       cleared_(true),
       has_been_bound_(false),
@@ skipping 127 matching lines @@
     if (impl_format == GL_DEPTH_COMPONENT16 && depth24_supported_)
       return GL_DEPTH_COMPONENT24;
   }
   return impl_format;
 }
 
 }  // namespace gles2
 }  // namespace gpu