Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 59323007: Make dbus-based wifi data provider optional on linux (Closed)

Created:
7 years, 1 month ago by spang
Modified:
7 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Michael van Ouwerkerk
Visibility:
Public.

Description

Make dbus-based wifi data provider optional on linux The linux wifi data provider adds an external dependency on libdbus. This prevents building content_browser on linux systems that don't include it (particularly embedded ones such as chromecast). Introduce use_dbus gyp variable and remove this dependency when use_dbus==0. BUG=318315, 318413 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234894

Patch Set 1 #

Total comments: 1

Patch Set 2 : reorder gyp variable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -8 lines) Patch
M build/common.gypi View 1 2 chunks +8 lines, -0 lines 0 comments Download
M content/browser/geolocation/empty_wifi_data_provider.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/content_browser.gypi View 5 chunks +21 lines, -5 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
spang
7 years, 1 month ago (2013-11-12 19:23:20 UTC) #1
jam
can you explain the motivation more? is there an actual product that needs this?
7 years, 1 month ago (2013-11-12 21:07:40 UTC) #2
spang
On 2013/11/12 21:07:40, jam wrote: > can you explain the motivation more? is there an ...
7 years, 1 month ago (2013-11-12 22:06:29 UTC) #3
jam
lgtm, thanks for creating the bug https://codereview.chromium.org/59323007/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/59323007/diff/1/build/common.gypi#newcode824 build/common.gypi:824: 'use_dbus%': '<(use_dbus)', nit: ...
7 years, 1 month ago (2013-11-13 00:05:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/59323007/100001
7 years, 1 month ago (2013-11-13 02:02:13 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=223604
7 years, 1 month ago (2013-11-13 06:05:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/59323007/100001
7 years, 1 month ago (2013-11-13 15:32:33 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-13 16:34:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/59323007/100001
7 years, 1 month ago (2013-11-13 16:36:07 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 20:44:54 UTC) #10
Message was sent while issue was closed.
Change committed as 234894

Powered by Google App Engine
This is Rietveld 408576698