Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 59323005: Cleanup: Remove unused includes of webkit/glue/webkit_glue.h (Closed)

Created:
7 years, 1 month ago by tfarina
Modified:
7 years, 1 month ago
CC:
chromium-reviews, extensions-reviews_chromium.org, grt+watch_chromium.org, rpetterson, jam, rouslan+spellwatch_chromium.org, amit, joi+watch-content_chromium.org, robertshield, dcheng, darin-cc_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, jochen+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Remove unused includes of webkit/glue/webkit_glue.h This patch was generated by: $ git grep -l webkit/glue/webkit_glue.h > list.txt $ for f in $(cat list.txt); do if ! grep -q 'PlatformFileInfoToWebFileInfo' $f ; then echo $f; fi; done $ for f in $(cat list.txt); do if ! grep -q 'SetJavaScript' $f ; then echo $f; fi; done BUG=None TEST=unit_tests, content_unittests R=thestig@chromium.org TBR=joth,avi,jamesr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234409

Patch Set 1 #

Patch Set 2 : fix win #

Patch Set 3 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -30 lines) Patch
M android_webview/native/aw_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/localized_error.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/chrome_render_view_observer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/extensions/extension_custom_bindings.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/renderer_glue.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/child/child_thread.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/npapi/npobject_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/plugin/plugin_thread.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/image_loading_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/webclipboard_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/mock_webclipboard_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/webkit_support_glue.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M content/worker/worker_thread.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/child/webkitplatformsupport_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/webkit_glue_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tfarina
Hi Lei, could you review this to me? I'll TBR the rest for the other ...
7 years, 1 month ago (2013-11-12 01:17:05 UTC) #1
Lei Zhang
lgtm
7 years, 1 month ago (2013-11-12 01:27:14 UTC) #2
tfarina
TBRing OWNERS for: Jonathan -> android_webview Avi -> content James -> webkit
7 years, 1 month ago (2013-11-12 01:29:13 UTC) #3
jamesr
Looks cool, but doesn't compile on windows.
7 years, 1 month ago (2013-11-12 01:40:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/59323005/1
7 years, 1 month ago (2013-11-12 01:42:18 UTC) #5
tfarina
On 2013/11/12 01:40:19, jamesr wrote: > Looks cool, but doesn't compile on windows. Thanks, fixed ...
7 years, 1 month ago (2013-11-12 01:46:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/59323005/150001
7 years, 1 month ago (2013-11-12 02:19:56 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 05:13:28 UTC) #8
Message was sent while issue was closed.
Change committed as 234409

Powered by Google App Engine
This is Rietveld 408576698