Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 59323004: Android: moves base/ to use long for JNI. (Closed)

Created:
7 years, 1 month ago by bulach
Modified:
7 years, 1 month ago
Reviewers:
Mark Mentovai, rmcilroy
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Visibility:
Public.

Description

Android: moves base/ to use long for JNI. Follow up from crrev.com/234212 BUG=317523 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235725

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M base/android/java/src/org/chromium/base/SystemMessageHandler.java View 2 chunks +4 lines, -4 lines 0 comments Download
M base/message_loop/message_pump_android.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bulach
ptal
7 years, 1 month ago (2013-11-11 13:29:37 UTC) #1
rmcilroy
lgtm
7 years, 1 month ago (2013-11-11 13:58:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/59323004/1
7 years, 1 month ago (2013-11-11 14:00:07 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=35449
7 years, 1 month ago (2013-11-11 14:15:53 UTC) #4
bulach
mark for base/message_loop OWNERS. thanks!
7 years, 1 month ago (2013-11-11 14:24:22 UTC) #5
bulach
mark? :)
7 years, 1 month ago (2013-11-15 17:27:35 UTC) #6
Mark Mentovai
LGTM. Sorry for the delay.
7 years, 1 month ago (2013-11-15 21:42:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/59323004/1
7 years, 1 month ago (2013-11-18 10:06:15 UTC) #8
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 12:17:43 UTC) #9
Message was sent while issue was closed.
Change committed as 235725

Powered by Google App Engine
This is Rietveld 408576698