Mac: Don't relayout tabs if the tab strip's frame didn't change.

Mac: Don't relayout tabs if the tab strip's frame didn't change.

When we reshow the find bar after dropping a tab into a new window,
-[BrowserWindowController layoutSubviews] is called which causes a relayout of
the tabs (without animation). In this case, a tab is in the beginning of being
animated to a new position and this relayout interrupted it by calling setFrame
on the tab view, but the tab frame ended up being the animator's target frame
instead of the relayout setFrame. This seems like an AppKit bug because it
behaves as expected on 10.9.

It is undesirable for layoutSubviews to force tabs relayout when the tap strip's
frame did not change, because it will interrupt tab animations in progress.
This change compares the old and new tab strip frame and skips tabs relayout
if the frame did not change.

BUG=415093
Committed: https://crrev.com/96003d8405aa0f715a6ebf48f25d5cfcbd715107
Cr-Commit-Position: refs/heads/master@{#296479}

[Andre, 2014-09-23 18:44:34]

andresantoso@chromium.org changed reviewers:
+ rsesek@chromium.org

[Andre, 2014-09-23 18:44:35]

Robert, please review.

[Robert Sesek, 2014-09-24 17:23:31]

https://codereview.chromium.org/593223002/diff/1/chrome/browser/ui/cocoa/brow...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/593223002/diff/1/chrome/browser/ui/cocoa/brow...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:263: if
(!NSEqualRects(tabStripFrame, [tabStripView frame])) {
I'd copy part of the CL description to a comment here.

[Andre, 2014-09-24 17:59:38]

https://codereview.chromium.org/593223002/diff/1/chrome/browser/ui/cocoa/brow...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/593223002/diff/1/chrome/browser/ui/cocoa/brow...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:263: if
(!NSEqualRects(tabStripFrame, [tabStripView frame])) {
On 2014/09/24 17:23:30, rsesek wrote:
> I'd copy part of the CL description to a comment here.

Done.

[Robert Sesek, 2014-09-24 18:02:09]

LGTM

[Andre, 2014-09-24 18:05:15]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2014-09-24 18:05:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/593223002/20001

[commit-bot: I haz the power, 2014-09-24 18:48:08]

Committed patchset #2 (id:20001) as fff2d165cb5e97fb321ff33ee18eedef3d2015f9

[commit-bot: I haz the power, 2014-09-24 18:49:42]

Patchset 2 (id:??) landed as
https://crrev.com/96003d8405aa0f715a6ebf48f25d5cfcbd715107
Cr-Commit-Position: refs/heads/master@{#296479}