Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Unified Diff: net/quic/quic_connection.cc

Issue 593193004: Call QuicSentPacketManager's OnPacketSent method and make (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Change_the_return_type_75724127
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_sent_packet_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index 3084e17aaa1ce771f0e74719c0f098752121d23d..5db2435a347d1ed4e7aec797aacaeb7bef52d6c6 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -1442,24 +1442,17 @@ bool QuicConnection::WritePacketInner(QueuedPacket* packet) {
sent_packet_manager_.least_packet_awaited_by_peer(),
sent_packet_manager_.GetCongestionWindow());
- if (packet->original_sequence_number == 0) {
- sent_packet_manager_.OnSerializedPacket(packet->serialized_packet);
- } else {
- if (debug_visitor_.get() != NULL) {
- debug_visitor_->OnPacketRetransmitted(
- packet->original_sequence_number, sequence_number);
- }
- sent_packet_manager_.OnRetransmittedPacket(packet->original_sequence_number,
- sequence_number);
+ if (packet->original_sequence_number != 0 && debug_visitor_.get() != NULL) {
+ debug_visitor_->OnPacketRetransmitted(
+ packet->original_sequence_number, sequence_number);
}
bool reset_retransmission_alarm = sent_packet_manager_.OnPacketSent(
- sequence_number,
+ &packet->serialized_packet,
+ packet->original_sequence_number,
now,
encrypted->length(),
packet->transmission_type,
IsRetransmittable(*packet));
- // The SentPacketManager now owns the retransmittable frames.
- packet->serialized_packet.retransmittable_frames = NULL;
if (reset_retransmission_alarm || !retransmission_alarm_->IsSet()) {
retransmission_alarm_->Update(sent_packet_manager_.GetRetransmissionTime(),
« no previous file with comments | « no previous file | net/quic/quic_sent_packet_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698