Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 593183002: history: tweak some cursor and outline related styles. (Closed)

Created:
6 years, 3 months ago by Dan Beam
Modified:
6 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

history: tweak some cursor and outline related styles. R=estade@chromium.org BUG=416761 Committed: https://crrev.com/c0eeabce5a81bd4a011f27b082f970abb55568d8 Cr-Commit-Position: refs/heads/master@{#296275}

Patch Set 1 #

Total comments: 2

Patch Set 2 : change comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M chrome/browser/resources/history/history.css View 1 5 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Dan Beam
6 years, 3 months ago (2014-09-23 18:03:25 UTC) #1
Evan Stade
lgtm https://codereview.chromium.org/593183002/diff/1/chrome/browser/resources/history/history.css File chrome/browser/resources/history/history.css (right): https://codereview.chromium.org/593183002/diff/1/chrome/browser/resources/history/history.css#newcode259 chrome/browser/resources/history/history.css:259: /* An odd line-height ensures a consistent baseline ...
6 years, 3 months ago (2014-09-23 20:41:30 UTC) #2
Dan Beam
https://codereview.chromium.org/593183002/diff/1/chrome/browser/resources/history/history.css File chrome/browser/resources/history/history.css (right): https://codereview.chromium.org/593183002/diff/1/chrome/browser/resources/history/history.css#newcode259 chrome/browser/resources/history/history.css:259: /* An odd line-height ensures a consistent baseline on ...
6 years, 3 months ago (2014-09-23 20:55:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593183002/20001
6 years, 3 months ago (2014-09-23 20:56:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b8c6fe4008c7a4dd7443a62eb3e102f745573eda
6 years, 3 months ago (2014-09-23 22:02:51 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 22:03:33 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0eeabce5a81bd4a011f27b082f970abb55568d8
Cr-Commit-Position: refs/heads/master@{#296275}

Powered by Google App Engine
This is Rietveld 408576698