Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 593173002: Change SVG paint server fallback for a non-existent URL (Closed)

Created:
6 years, 3 months ago by fs
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Change SVG paint server fallback for a non-existent URL SVG2 changed the behavior from "...the document is in error" to "...it must be treated as if none was specified". BUG=416580 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182616

Patch Set 1 #

Patch Set 2 : Adjust tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -142 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/svg/custom/fill-fallback-invalid-uri.html View 1 chunk +5 lines, -0 lines 0 comments Download
A + LayoutTests/svg/custom/fill-fallback-invalid-uri-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/svg/custom/invalid-fill.svg View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/svg/custom/invalid-fill-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/svg/custom/invalid-uri-stroke.svg View 1 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/svg/custom/invalid-uri-stroke-expected.txt View 1 1 chunk +0 lines, -28 lines 0 comments Download
M LayoutTests/svg/custom/recursive-pattern.svg View 1 2 chunks +5 lines, -5 lines 0 comments Download
A LayoutTests/svg/custom/stroke-fallback-invalid-uri.html View 1 1 chunk +5 lines, -0 lines 0 comments Download
A + LayoutTests/svg/custom/stroke-fallback-invalid-uri-expected.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D LayoutTests/svg/hixie/error/003.xml View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/svg/hixie/error/003-expected.txt View 1 1 chunk +0 lines, -15 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResource.cpp View 2 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
6 years, 3 months ago (2014-09-24 09:27:54 UTC) #2
Erik Dahlström (inactive)
Non-owner LGTM.
6 years, 3 months ago (2014-09-24 11:44:46 UTC) #3
pdr.
On 2014/09/24 11:44:46, Erik Dahlström wrote: > Non-owner LGTM. LGTM
6 years, 3 months ago (2014-09-24 17:00:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593173002/20001
6 years, 3 months ago (2014-09-24 17:01:05 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 17:06:20 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 182616

Powered by Google App Engine
This is Rietveld 408576698