chrome/test/data/extensions/api_test/bluetooth_low_energy/read_descriptor_value/runtest.js - Issue 593163002: Short-circuit failures in BLE js tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/bluetooth_low_energy/read_descriptor_value/runtest.js

Issue 593163002: Short-circuit failures in BLE js tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Testing new cls Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/bluetooth_low_energy/read_characteristic_value/runtest.js ('k') | chrome/test/data/extensions/api_test/bluetooth_low_energy/start_stop_notifications/runtest.js » ('j') | extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/bluetooth_low_energy/read_descriptor_value/runtest.js

diff --git a/chrome/test/data/extensions/api_test/bluetooth_low_energy/read_descriptor_value/runtest.js b/chrome/test/data/extensions/api_test/bluetooth_low_energy/read_descriptor_value/runtest.js

index e7693a96ae9fdf73eba67784d0d48c62f885a8fd..c813b797c3fdc0348d5e7419a1655a577475ca64 100644

--- a/chrome/test/data/extensions/api_test/bluetooth_low_energy/read_descriptor_value/runtest.js

+++ b/chrome/test/data/extensions/api_test/bluetooth_low_energy/read_descriptor_value/runtest.js

@@ -18,19 +18,19 @@ var descriptor = null;

// 1. Unknown descriptor instanceId.

readDescriptorValue(badDescId, function (result) {

if (result || !chrome.runtime.lastError) {

- chrome.test.fail('\'badDescId\' did not cause failure');

+ chrome.test.sendMessage('\'badDescId\' did not cause failure');

}

// 2. Known descriptor instanceId, but call failure.

readDescriptorValue(descId, function (result) {

if (result || !chrome.runtime.lastError) {

- chrome.test.fail('readDescriptorValue should have failed');

+ chrome.test.sendMessage('readDescriptorValue should have failed');

}

// 3. Call should succeed.

readDescriptorValue(descId, function (result) {

if (chrome.runtime.lastError) {

- chrome.test.fail(chrome.runtime.lastError.message);

+ chrome.test.sendMessage(chrome.runtime.lastError.message);

}

descriptor = result;