Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chrome/test/data/extensions/api_test/bluetooth_low_energy/get_descriptor/runtest.js

Issue 593163002: Short-circuit failures in BLE js tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Testing new cls Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/bluetooth_low_energy/get_descriptor/runtest.js
diff --git a/chrome/test/data/extensions/api_test/bluetooth_low_energy/get_descriptor/runtest.js b/chrome/test/data/extensions/api_test/bluetooth_low_energy/get_descriptor/runtest.js
index 49418e4926f681b302a4331bffe07574ded54c1c..17712bad3d010e7323df9a9591dc4b937c460c77 100644
--- a/chrome/test/data/extensions/api_test/bluetooth_low_energy/get_descriptor/runtest.js
+++ b/chrome/test/data/extensions/api_test/bluetooth_low_energy/get_descriptor/runtest.js
@@ -30,39 +30,40 @@ var descriptor = null;
// 1. Unknown descriptor instanceId.
getDescriptor(badDescId, function (result) {
if (result || !chrome.runtime.lastError) {
- chrome.test.fail('getDescriptor should have failed for \'badDescId\'');
+ chrome.test.sendMessage('getDescriptor should have failed ' +
+ 'for \'badDescId\'');
}
// 2. Known descriptor instanceId, but the mapped device is unknown.
getDescriptor(descId, function (result) {
if (result || !chrome.runtime.lastError) {
- chrome.test.fail('getDescriptor should have failed');
+ chrome.test.sendMessage('getDescriptor should have failed');
}
// 3. Known descriptor instanceId, but the mapped service is unknown.
getDescriptor(descId, function (result) {
if (result || !chrome.runtime.lastError) {
- chrome.test.fail('getDescriptor should have failed');
+ chrome.test.sendMessage('getDescriptor should have failed');
}
// 4. Known descriptor instanceId, but the mapped characteristic is
// unknown.
getDescriptor(descId, function (result) {
if (result || !chrome.runtime.lastError) {
- chrome.test.fail('getDescriptor should have failed');
+ chrome.test.sendMessage('getDescriptor should have failed');
}
// 5. Known descriptor instanceId, but the mapped the characteristic
// does not know about the descriptor.
getDescriptor(descId, function (result) {
if (result || !chrome.runtime.lastError) {
- chrome.test.fail('getDescriptor should have failed');
+ chrome.test.sendMessage('getDescriptor should have failed');
}
// 6. Success.
getDescriptor(descId, function (result) {
if (chrome.runtime.lastError) {
- chrome.test.fail(chrome.runtime.lastError.message);
+ chrome.test.sendMessage(chrome.runtime.lastError.message);
}
descriptor = result;

Powered by Google App Engine
This is Rietveld 408576698