Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4949)

Unified Diff: chrome/test/data/extensions/api_test/bluetooth_low_energy/get_characteristic/runtest.js

Issue 593163002: Short-circuit failures in BLE js tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Testing new cls Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/bluetooth_low_energy/get_characteristic/runtest.js
diff --git a/chrome/test/data/extensions/api_test/bluetooth_low_energy/get_characteristic/runtest.js b/chrome/test/data/extensions/api_test/bluetooth_low_energy/get_characteristic/runtest.js
index be2cd4584ece08733d12485237eff676f537d87f..d21376fb5213c1ce5e5a6c208e7008324462d4da 100644
--- a/chrome/test/data/extensions/api_test/bluetooth_low_energy/get_characteristic/runtest.js
+++ b/chrome/test/data/extensions/api_test/bluetooth_low_energy/get_characteristic/runtest.js
@@ -41,32 +41,33 @@ var characteristic = null;
// 1. Unknown characteristic instanceId.
chrome.bluetoothLowEnergy.getCharacteristic(badCharId, function (result) {
if (result || !chrome.runtime.lastError) {
- chrome.test.fail('getCharacteristics should have failed');
+ chrome.test.sendMessage('getCharacteristics should have failed');
}
// 2. Known characteristic instanceId, but the mapped device is unknown.
chrome.bluetoothLowEnergy.getCharacteristic(charId, function (result) {
if (result || !chrome.runtime.lastError) {
- chrome.test.fail('getCharacteristics should have failed');
+ chrome.test.sendMessage('getCharacteristics should have failed');
}
// 3. Known characteristic instanceId, but the mapped service is unknown.
chrome.bluetoothLowEnergy.getCharacteristic(charId, function (result) {
if (result || !chrome.runtime.lastError) {
- chrome.test.fail('getCharacteristics should have failed');
+ chrome.test.sendMessage('getCharacteristics should have failed');
}
// 4. Known characteristic instanceId, but the mapped service does not
// know about the characteristic.
chrome.bluetoothLowEnergy.getCharacteristic(charId, function (result) {
if (result || !chrome.runtime.lastError) {
- chrome.test.fail('getCharacteristics should have failed');
+ chrome.test.sendMessage('getCharacteristics should have failed');
}
// 5. Success.
chrome.bluetoothLowEnergy.getCharacteristic(charId, function (result) {
if (chrome.runtime.lastError) {
- chrome.test.fail(chrome.runtime.lastError.message);
+ chrome.test.sendMessage("Unexpected error: "
+ + chrome.runtime.lastError.message);
}
characteristic = result;

Powered by Google App Engine
This is Rietveld 408576698