Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3590)

Unified Diff: chrome/browser/content_settings/permission_context_base.h

Issue 593153002: Restore the iframe behavior of notification permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/content_settings/permission_queue_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/content_settings/permission_context_base.h
diff --git a/chrome/browser/content_settings/permission_context_base.h b/chrome/browser/content_settings/permission_context_base.h
index 1db872b39c4e903aa901e2839f0d7660dc15da13..bb5c68a96114631f8536d5ef36eb7fa137238084 100644
--- a/chrome/browser/content_settings/permission_context_base.h
+++ b/chrome/browser/content_settings/permission_context_base.h
@@ -98,11 +98,14 @@ class PermissionContextBase : public KeyedService {
// Return an instance of the infobar queue controller, creating it if needed.
PermissionQueueController* GetQueueController();
+ // Store the decided permission as a content setting.
+ // virtual since the permission might be stored with different restrictions
+ // (for example for desktop notifications).
+ virtual void UpdateContentSetting(const GURL& requesting_origin,
+ const GURL& embedder_origin,
+ bool allowed);
+
private:
- void UpdateContentSetting(
- const GURL& requesting_origin,
- const GURL& embedder_origin,
- bool allowed);
// Called when a bubble is no longer used so it can be cleaned up.
void CleanUpBubble(const PermissionRequestID& id);
« no previous file with comments | « no previous file | chrome/browser/content_settings/permission_queue_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698