chrome/browser/content_settings/permission_context_base.h - Issue 593153002: Restore the iframe behavior of notification permissions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/permission_context_base.h

Issue 593153002: Restore the iframe behavior of notification permissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/content_settings/permission_queue_controller.cc » ('j') | chrome/browser/content_settings/permission_queue_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/permission_context_base.h

diff --git a/chrome/browser/content_settings/permission_context_base.h b/chrome/browser/content_settings/permission_context_base.h

index 1db872b39c4e903aa901e2839f0d7660dc15da13..93cec3c862e47109dd6e7ad4a091df90fbcb208f 100644

--- a/chrome/browser/content_settings/permission_context_base.h

+++ b/chrome/browser/content_settings/permission_context_base.h

@@ -98,11 +98,12 @@ class PermissionContextBase : public KeyedService {

// Return an instance of the infobar queue controller, creating it if needed.

PermissionQueueController* GetQueueController();

+ // Store the decided permission as a content setting.

Bernhard Bauer 2014/09/23 16:13:01 Please add a comment that explains why this is vir

Miguel Garcia 2014/09/23 16:53:38 Done.

+ virtual void UpdateContentSetting(const GURL& requesting_origin,

+ const GURL& embedder_origin,

+ bool allowed);

private:

- void UpdateContentSetting(

- const GURL& requesting_origin,

- const GURL& embedder_origin,

- bool allowed);

// Called when a bubble is no longer used so it can be cleaned up.

void CleanUpBubble(const PermissionRequestID& id);