Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: chrome/browser/resources/chromeos/chromevox/walkers/table_shifter.js

Issue 593133002: Refactor: remove a Chromevox abstract class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview Walkers to traverse a table. 6 * @fileoverview Walkers to traverse a table.
7 */ 7 */
8 8
9 9
10 goog.provide('cvox.TableShifter'); 10 goog.provide('cvox.TableShifter');
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 * @override 63 * @override
64 */ 64 */
65 cvox.TableShifter.prototype.getName = function() { 65 cvox.TableShifter.prototype.getName = function() {
66 return cvox.ChromeVox.msgs.getMsg('table_shifter'); 66 return cvox.ChromeVox.msgs.getMsg('table_shifter');
67 }; 67 };
68 68
69 69
70 /** 70 /**
71 * @override 71 * @override
72 * @suppress {checkTypes} actual parameter 2 of 72 * @suppress {checkTypes} actual parameter 2 of
73 * cvox.AbstractMsgs.prototype.getMsg does not match formal parameter 73 * cvox.Msgs.prototype.getMsg does not match formal parameter
74 * found : Array.<number> 74 * found : Array.<number>
75 * required: (Array.<string>|null|undefined) 75 * required: (Array.<string>|null|undefined)
76 */ 76 */
77 cvox.TableShifter.prototype.getDescription = function(prevSel, sel) { 77 cvox.TableShifter.prototype.getDescription = function(prevSel, sel) {
78 var descs = this.currentWalker_.getDescription(prevSel, sel); 78 var descs = this.currentWalker_.getDescription(prevSel, sel);
79 if (descs.length > 0) { 79 if (descs.length > 0) {
80 if (this.bumpedEdge_) { 80 if (this.bumpedEdge_) {
81 descs[0].pushEarcon(cvox.AbstractEarcons.WRAP_EDGE); 81 descs[0].pushEarcon(cvox.AbstractEarcons.WRAP_EDGE);
82 this.bumpedEdge_ = false; 82 this.bumpedEdge_ = false;
83 } 83 }
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 * @override 143 * @override
144 */ 144 */
145 cvox.TableShifter.create = function(sel) { 145 cvox.TableShifter.create = function(sel) {
146 var ancestors = cvox.DomUtil.getAncestors(sel.start.node); 146 var ancestors = cvox.DomUtil.getAncestors(sel.start.node);
147 if (cvox.DomPredicates.tablePredicate(ancestors) && 147 if (cvox.DomPredicates.tablePredicate(ancestors) &&
148 !cvox.DomPredicates.captionPredicate(ancestors)) { 148 !cvox.DomPredicates.captionPredicate(ancestors)) {
149 return new cvox.TableShifter(); 149 return new cvox.TableShifter();
150 } 150 }
151 return null; 151 return null;
152 }; 152 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698