Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 593123002: Fix compilation of Chromium on a case-sensitive FS on Mac OS X (Closed)

Created:
6 years, 3 months ago by sdefresne
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix compilation of Chromium on a case-sensitive FS on Mac OS X The Resources folder need to have that capitalization otherwise when building on a case-sensitive filesystem the build results in two directories: Chromium Framework.framework/Versions/A/resources/ Chromium Framework.framework/Versions/A/Resources/ This ultimately lead to a compilation error when running the script tools/swarming_client/isolated_format.py. BUG=260301 Committed: https://crrev.com/9665a5dc04b0b872c3117e3fc40024c6436c6963 Cr-Commit-Position: refs/heads/master@{#296379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/chrome_dll_bundle.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
sdefresne
Please take a look.
6 years, 3 months ago (2014-09-23 13:50:16 UTC) #2
Nico
lgtm, but who uses a case-sensitive fs? (note: you sent this to "chomium.org", so i ...
6 years, 3 months ago (2014-09-23 16:50:56 UTC) #4
sdefresne
On 2014/09/23 16:50:56, Nico (hiding) wrote: > lgtm, but who uses a case-sensitive fs? > ...
6 years, 3 months ago (2014-09-24 09:36:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593123002/1
6 years, 3 months ago (2014-09-24 09:37:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as e923696bdaaa1467d31c526c0867269d9ce8853f
6 years, 3 months ago (2014-09-24 10:05:42 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9665a5dc04b0b872c3117e3fc40024c6436c6963 Cr-Commit-Position: refs/heads/master@{#296379}
6 years, 3 months ago (2014-09-24 10:06:46 UTC) #10
Nico
6 years, 3 months ago (2014-09-24 13:15:57 UTC) #11
All of them? Why?
On Sep 24, 2014 2:36 AM, <sdefresne@chromium.org> wrote:

> On 2014/09/23 16:50:56, Nico (hiding) wrote:
>
>> lgtm, but who uses a case-sensitive fs?
>>
>
>  (note: you sent this to "chomium.org", so i didn't receive an email)
>>
>
> People working on iOS do.
>
> https://codereview.chromium.org/593123002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698