Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 593113003: Add test support for setting selected text option for <select> multiple (Closed)

Created:
6 years, 3 months ago by spartha
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add test support for setting selected text option for <select> multiple The test framework returns an empty string as the localized strings are not supported. This caused the assert to fail on android debug builds, because of which https://codereview.chromium.org/541693003/ had to be reverted. This is the chromium side changes needed for the patch to be restored. BUG=401506 Committed: https://crrev.com/bbfffe3bea9695231681aed4d3d4d23d09ced5b6 Cr-Commit-Position: refs/heads/master@{#296648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/test/test_webkit_platform_support.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
spartha
This change is needed to restore https://codereview.chromium.org/541693003/ PTAL...Thanks!
6 years, 3 months ago (2014-09-23 13:55:22 UTC) #4
tkent
non-owner lgtm
6 years, 3 months ago (2014-09-23 22:43:16 UTC) #5
spartha
On 2014/09/23 22:43:16, tkent (high review load) wrote: > non-owner lgtm @darin, @jochen could one ...
6 years, 3 months ago (2014-09-24 07:36:32 UTC) #6
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-24 20:06:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593113003/1
6 years, 3 months ago (2014-09-25 04:08:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 3fe7f6c108d9a46e8f70a0999c5e752528ab9d81
6 years, 3 months ago (2014-09-25 05:00:46 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-25 05:01:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbfffe3bea9695231681aed4d3d4d23d09ced5b6
Cr-Commit-Position: refs/heads/master@{#296648}

Powered by Google App Engine
This is Rietveld 408576698