Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 593113002: Reusing the base::StringPairs in src/components/* (Closed)

Created:
6 years, 2 months ago by ARUNKK
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reusing the base::StringPairs in src/components/* Reusing the "base::StringPairs" insted of "std::vector<std::pair<std::string, std::string> >" same is defined in base/strings/string_split.h. BUG=412250 Committed: https://crrev.com/db60fc29b755f1cc3e7846497cb54222e3f391de Cr-Commit-Position: refs/heads/master@{#297387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M components/leveldb_proto/proto_database_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/device_management_service.h View 2 chunks +3 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/device_management_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search/search.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (7 generated)
ARUNKK
PTAL
6 years, 2 months ago (2014-09-23 13:24:22 UTC) #2
Mike West
Drive-by LGTM, this is a nice readability improvement. You'll still need a //components OWNER to ...
6 years, 2 months ago (2014-09-26 11:37:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593113002/1
6 years, 2 months ago (2014-09-26 13:22:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/13778)
6 years, 2 months ago (2014-09-26 13:34:26 UTC) #8
Mike West
On 2014/09/26 13:34:26, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-09-26 13:35:09 UTC) #9
ARUNKK
On 2014/09/26 11:37:11, Mike West wrote: > Drive-by LGTM, this is a nice readability improvement. ...
6 years, 2 months ago (2014-09-26 18:18:56 UTC) #10
ARUNKK
On 2014/09/26 18:18:56, ARUNKK wrote: > On 2014/09/26 11:37:11, Mike West wrote: > > Drive-by ...
6 years, 2 months ago (2014-09-30 05:28:04 UTC) #11
jochen (gone - plz use gerrit)
lgtm
6 years, 2 months ago (2014-09-30 08:42:48 UTC) #12
ARUNKK
On 2014/09/30 08:42:48, jochen (slow for reviews) wrote: > lgtm Thanks for LGTM
6 years, 2 months ago (2014-09-30 08:48:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593113002/1
6 years, 2 months ago (2014-09-30 08:49:19 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1) as 94cbac3923be1f0b52dc09a9f0cf7e848c9957a9
6 years, 2 months ago (2014-09-30 08:54:08 UTC) #18
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 08:56:24 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db60fc29b755f1cc3e7846497cb54222e3f391de
Cr-Commit-Position: refs/heads/master@{#297387}

Powered by Google App Engine
This is Rietveld 408576698