Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 593103002: Enable gaia services for enterprise autotests. (Closed)

Created:
6 years, 3 months ago by achuithb
Modified:
6 years, 2 months ago
Reviewers:
kaliamoorthi
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable gaia services for enterprise autotests. BUG=416803 TEST=manual Committed: https://crrev.com/8df3134463b63a375f7109ae28fe78ea3b2af12f Cr-Commit-Position: refs/heads/master@{#296914}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_options.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py View 1 chunk +4 lines, -1 line 1 comment Download

Messages

Total messages: 9 (2 generated)
achuithb
Prabhu,please review.
6 years, 3 months ago (2014-09-23 13:02:59 UTC) #2
kaliamoorthi
https://codereview.chromium.org/593103002/diff/1/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py File tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py (right): https://codereview.chromium.org/593103002/diff/1/tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py#newcode87 tools/telemetry/telemetry/core/backends/chrome/cros_browser_backend.py:87: if (self.browser_options.disable_gaia_services and Not sure why we need this ...
6 years, 2 months ago (2014-09-25 15:47:27 UTC) #3
kaliamoorthi
LGTM
6 years, 2 months ago (2014-09-26 09:03:29 UTC) #4
achuithb
On 2014/09/26 09:03:29, kaliamoorthi wrote: > LGTM ty
6 years, 2 months ago (2014-09-26 09:06:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593103002/1
6 years, 2 months ago (2014-09-26 09:07:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0ea43ebfdffa597bb71db967067a97fbce5b0468
6 years, 2 months ago (2014-09-26 10:19:13 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 10:19:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8df3134463b63a375f7109ae28fe78ea3b2af12f
Cr-Commit-Position: refs/heads/master@{#296914}

Powered by Google App Engine
This is Rietveld 408576698