Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: chrome/browser/sync/syncable/syncable.cc

Issue 593094: Add unique hashing to sync API. (Closed)
Patch Set: New unit test, review fixes. Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/syncable/syncable.cc
diff --git a/chrome/browser/sync/syncable/syncable.cc b/chrome/browser/sync/syncable/syncable.cc
index ff0ab77479dbb17b272590aebaef86210d07727b..fb37c3a5f372942ab32538bb3781ef0256573cfa 100755
--- a/chrome/browser/sync/syncable/syncable.cc
+++ b/chrome/browser/sync/syncable/syncable.cc
@@ -1076,15 +1076,6 @@ syncable::ModelType Entry::GetModelType() const {
if (!Get(UNIQUE_SERVER_TAG).empty() && Get(IS_DIR))
return TOP_LEVEL_FOLDER;
ncarter (slow) 2010/02/18 01:05:40 It's probably okay for these DCHECKs to die -- but
chron 2010/02/18 01:09:32 These dchecks weren't really valid since we call G
- // Otherwise, we don't have a local type yet. That should only happen
- // if the item doesn't exist locally -- like if it's a new update item.
- // It's possible we'll need to relax these checks in the future; they're
- // just here for now as a safety measure.
- DCHECK(Get(ID).ServerKnows());
- DCHECK(Get(IS_UNAPPLIED_UPDATE));
- DCHECK(!Get(IS_UNSYNCED));
- DCHECK(Get(BASE_VERSION) == CHANGES_VERSION);
- DCHECK(Get(IS_DEL));
return UNSPECIFIED;
}

Powered by Google App Engine
This is Rietveld 408576698