Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 593083002: Cleanup WebImageLayerImpl by removing setBitmap(SkBitmap) (Closed)

Created:
6 years, 3 months ago by vivekg_samsung
Modified:
6 years, 3 months ago
Reviewers:
jamesr, vivekg
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup WebImageLayerImpl by removing setBitmap(SkBitmap) The method WebImageLayer::setBitmap(SkBitmap) is no longer available and should be removed from the WebImageLayerImpl as well. R=jamesr@chromium.org NOTRY=true Committed: https://crrev.com/4780848e7fc5f8636c3bece8e689c6586cf2f0fd Cr-Commit-Position: refs/heads/master@{#296322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M cc/blink/web_image_layer_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/blink/web_image_layer_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
vivekg
PTAL, thanks!
6 years, 3 months ago (2014-09-23 11:41:44 UTC) #2
jamesr
lgtm
6 years, 3 months ago (2014-09-23 23:27:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593083002/1
6 years, 3 months ago (2014-09-24 00:28:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/17835) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/17768) ios_rel_device_ninja ...
6 years, 3 months ago (2014-09-24 00:33:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593083002/1
6 years, 3 months ago (2014-09-24 01:00:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/builds/17809) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/12571)
6 years, 3 months ago (2014-09-24 01:04:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593083002/1
6 years, 3 months ago (2014-09-24 01:16:49 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6c91f0491fd0278d1b57b6e779f9089a60594a70
6 years, 3 months ago (2014-09-24 01:17:22 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 01:17:51 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4780848e7fc5f8636c3bece8e689c6586cf2f0fd
Cr-Commit-Position: refs/heads/master@{#296322}

Powered by Google App Engine
This is Rietveld 408576698