Stores and compound assignments for named super properties.

src/runtime.cc

Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index 3ecf04430a82632a615aab7f097f97a0959cda8d..7d83a1d673f97967b0d348624b4961a0fcf3cc73 100644
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -2083,8 +2083,8 @@ RUNTIME_FUNCTION(Runtime_HomeObjectSymbol) {
 RUNTIME_FUNCTION(Runtime_LoadFromSuper) {
   HandleScope scope(isolate);
   DCHECK(args.length() == 3);
-  CONVERT_ARG_HANDLE_CHECKED(JSObject, home_object, 0);
-  CONVERT_ARG_HANDLE_CHECKED(Object, receiver, 1);
+  CONVERT_ARG_HANDLE_CHECKED(Object, receiver, 0);
+  CONVERT_ARG_HANDLE_CHECKED(JSObject, home_object, 1);
   CONVERT_ARG_HANDLE_CHECKED(Name, name, 2);
 
   if (home_object->IsAccessCheckNeeded() &&
@@ -2104,6 +2104,54 @@ RUNTIME_FUNCTION(Runtime_LoadFromSuper) {
 }
 
 
+static Object* StoreToSuper(Isolate* isolate, Handle<JSObject> home_object,
+                            Handle<Object> receiver, Handle<Name> name,
+                            Handle<Object> value, StrictMode strict_mode) {
+  if (home_object->IsAccessCheckNeeded() &&
+      !isolate->MayNamedAccess(home_object, name, v8::ACCESS_SET)) {
+    isolate->ReportFailedAccessCheck(home_object, v8::ACCESS_SET);
+    RETURN_FAILURE_IF_SCHEDULED_EXCEPTION(isolate);
+  }
+
+  PrototypeIterator iter(isolate, home_object);
+  Handle<Object> proto = PrototypeIterator::GetCurrent(iter);
+  if (!proto->IsJSReceiver()) return isolate->heap()->undefined_value();

[arv (Not doing code reviews), 2014/09/24 14:53:57]

Is this correct? I believe the following should work

(function() {
  super.x = 1;
}.toMethod({
  set x(v) { print(v); {
}).call(42))

and print 1

[Dmitry Lomov (no reviews), 2014/09/24 16:23:46]

I have a bit of a hard time deciphering what you are trying to say. At the very
least, 
  super.x = 1 is [[HomeObject]].__proto__.[[Set]]('x',1,this), not
[[HomeObject]].[[Set]]('x',1,this), so the setter will not execute. 

[arv (Not doing code reviews), 2014/09/25 13:51:41]

I was trying to give an example where this is not an object, but a primitive.

[Dmitry Lomov (no reviews), 2014/09/25 13:59:59]

'this' is 'receiver' here, and it is an v8::intrenal::Object, so it can be
primitive. prototype of an object (what PrototypeIterator::GetCurrent returns)
has to be either object or null per spec, so line 2118 is valid. 

+
+  LookupIterator it(receiver, name, Handle<JSReceiver>::cast(proto));
+  Handle<Object> result;
+  ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
+      isolate, result,
+      Object::SetProperty(&it, value, strict_mode,
+                          Object::CERTAINLY_NOT_STORE_FROM_KEYED,
+                          Object::SUPER_PROPERTY));
+  return *result;
+}
+
+
+RUNTIME_FUNCTION(Runtime_StoreToSuper_Strict) {
+  HandleScope scope(isolate);
+  DCHECK(args.length() == 4);
+  CONVERT_ARG_HANDLE_CHECKED(Object, receiver, 0);
+  CONVERT_ARG_HANDLE_CHECKED(JSObject, home_object, 1);
+  CONVERT_ARG_HANDLE_CHECKED(Object, value, 2);
+  CONVERT_ARG_HANDLE_CHECKED(Name, name, 3);
+
+  return StoreToSuper(isolate, home_object, receiver, name, value, STRICT);
+}
+
+
+RUNTIME_FUNCTION(Runtime_StoreToSuper_Sloppy) {
+  HandleScope scope(isolate);
+  DCHECK(args.length() == 4);
+  CONVERT_ARG_HANDLE_CHECKED(Object, receiver, 0);
+  CONVERT_ARG_HANDLE_CHECKED(JSObject, home_object, 1);
+  CONVERT_ARG_HANDLE_CHECKED(Object, value, 2);
+  CONVERT_ARG_HANDLE_CHECKED(Name, name, 3);
+
+  return StoreToSuper(isolate, home_object, receiver, name, value, SLOPPY);
+}
+
+
 RUNTIME_FUNCTION(Runtime_IsExtensible) {
   SealHandleScope shs(isolate);
   DCHECK(args.length() == 1);