Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 593033002: Use base::StringPairs where appropriate from src/ui (Closed)

Created:
6 years, 3 months ago by Anand Ratn (left samsung)
Modified:
6 years, 3 months ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use base::StringPairs where appropriate from src/ui Becuase base/strings/string_split.h defines: typedef std::vector<std::pair<std::string, std::string> > StringPairs; BUG=412250 Committed: https://crrev.com/a85c48c21c31e2774d9788fbc77fa49f10863f35 Cr-Commit-Position: refs/heads/master@{#296206}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/accessibility/ax_node_data.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Anand Ratn (left samsung)
sky@chromium.org: Please review changes in src/ui module avi@chromium.org: Please review changes in src/ui module
6 years, 3 months ago (2014-09-23 11:43:56 UTC) #2
Avi (use Gerrit)
On 2014/09/23 11:43:56, anand.ratn wrote: > mailto:sky@chromium.org: Please review changes in src/ui module > > ...
6 years, 3 months ago (2014-09-23 14:05:03 UTC) #3
Anand Ratn (left samsung)
On 2014/09/23 14:05:03, Avi wrote: > On 2014/09/23 11:43:56, anand.ratn wrote: > > mailto:sky@chromium.org: Please ...
6 years, 3 months ago (2014-09-23 16:01:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/593033002/1
6 years, 3 months ago (2014-09-23 16:01:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as f488d755d38821da401fe2cab7b15d4842bb8c7c
6 years, 3 months ago (2014-09-23 16:50:36 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 16:51:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a85c48c21c31e2774d9788fbc77fa49f10863f35
Cr-Commit-Position: refs/heads/master@{#296206}

Powered by Google App Engine
This is Rietveld 408576698