Use base::StringPairs where appropriate for src/media/

Use base::StringPairs where appropriate for src/media/

Becuase base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250
Committed: https://crrev.com/2636d976fb583560c0817dc258a9e37578501bec
Cr-Commit-Position: refs/heads/master@{#297359}

[Anand Ratn (left samsung), 2014-09-23 11:49:39]

anand.ratn@samsung.com changed reviewers:
+ dalecurtis@chromium.org, scherkus@chromium.org

[Anand Ratn (left samsung), 2014-09-23 11:49:40]

dalecurtis@chromium.org: Please review changes in src/media module

scherkus@chromium.org: Please review changes in src/media module

[DaleCurtis, 2014-09-23 17:14:48]

https://codereview.chromium.org/593023002/diff/1/media/base/test_data_util.h
File media/base/test_data_util.h (right):

https://codereview.chromium.org/593023002/diff/1/media/base/test_data_util.h#...
media/base/test_data_util.h:22: typedef base::StringPairs QueryParams;
Looks like there's only a couple callers to GetURLQueryString, I think it'd be
better to drop this typedef and change them to StringPairs

[Anand Ratn (left samsung), 2014-09-24 12:17:59]

On 2014/09/23 17:14:48, DaleCurtis wrote:
> https://codereview.chromium.org/593023002/diff/1/media/base/test_data_util.h
> File media/base/test_data_util.h (right):
> 
>
https://codereview.chromium.org/593023002/diff/1/media/base/test_data_util.h#...
> media/base/test_data_util.h:22: typedef base::StringPairs QueryParams;
> Looks like there's only a couple callers to GetURLQueryString, I think it'd be
> better to drop this typedef and change them to StringPairs

Hi DaleCurtis: 

Thanks for the review .Changes are incorporated in new patchset. PTAL

[DaleCurtis, 2014-09-24 17:36:09]

You're missing some:

https://code.google.com/p/chromium/codesearch#search/&q=QueryParams%20test_da...

[Anand Ratn (left samsung), 2014-09-25 11:59:57]

On 2014/09/24 17:36:09, DaleCurtis wrote:
> You're missing some:
> 
>
https://code.google.com/p/chromium/codesearch#search/&q=QueryParams%20test_da...

DaleCurtis: PTAL at new patchset

[DaleCurtis, 2014-09-25 17:21:01]

lgtm

[Anand Ratn (left samsung), 2014-09-26 04:02:22]

The CQ bit was checked by anand.ratn@samsung.com

[commit-bot: I haz the power, 2014-09-26 04:03:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/593023002/40001

[commit-bot: I haz the power, 2014-09-26 04:22:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-26 04:22:40]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Anand Ratn (left samsung), 2014-09-26 10:49:02]

On 2014/09/26 04:22:40, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   android_dbg_tests_recipe on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
>   linux_chromium_rel_swarming on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Hi Dale,

I was thinking what if I change the 
| typedef std::vector<std::pair<std::string, std::string> > QueryParams; | =to=>
| base::StringPairs QueryParams |

in media/base/test_data_util.h. In this way we will not have to modify the these
many files.

Please suggest.

[DaleCurtis, 2014-09-26 18:46:56]

Please update the new failing files.  We don't typically prefer global duplicate
definitions like this.  Minimizing them is preferred.

[Anand Ratn (left samsung), 2014-09-29 09:18:44]

On 2014/09/26 18:46:56, DaleCurtis wrote:
> Please update the new failing files.  We don't typically prefer global
duplicate
> definitions like this.  Minimizing them is preferred.

Thanks Dale, I have updated the failing files. PTAL

[Anand Ratn (left samsung), 2014-09-29 09:20:09]

The CQ bit was checked by anand.ratn@samsung.com

[Anand Ratn (left samsung), 2014-09-29 09:20:10]

The CQ bit was unchecked by anand.ratn@samsung.com

[Anand Ratn (left samsung), 2014-09-29 09:25:20]

The CQ bit was checked by anand.ratn@samsung.com

[commit-bot: I haz the power, 2014-09-29 09:26:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/593023002/60001

[commit-bot: I haz the power, 2014-09-29 09:40:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 09:40:41]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Anand Ratn (left samsung), 2014-09-29 09:50:00]

The CQ bit was checked by anand.ratn@samsung.com

[commit-bot: I haz the power, 2014-09-29 09:50:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/593023002/80001

[Anand Ratn (left samsung), 2014-09-29 10:38:31]

The CQ bit was checked by anand.ratn@samsung.com

[commit-bot: I haz the power, 2014-09-29 10:39:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/593023002/100001

[commit-bot: I haz the power, 2014-09-29 10:58:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 10:58:09]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Anand Ratn (left samsung), 2014-09-29 11:49:39]

The CQ bit was checked by anand.ratn@samsung.com

[commit-bot: I haz the power, 2014-09-29 11:50:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/593023002/120001

[commit-bot: I haz the power, 2014-09-29 12:37:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 12:38:01]

Try jobs failed on following builders:
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Anand Ratn (left samsung), 2014-09-30 03:29:58]

The CQ bit was checked by anand.ratn@samsung.com

[commit-bot: I haz the power, 2014-09-30 03:37:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/593023002/120001

[commit-bot: I haz the power, 2014-09-30 04:07:05]

Committed patchset #7 (id:120001) as b74efb34d9dff95cc32ea87bb5306912c7e31b46

[commit-bot: I haz the power, 2014-09-30 04:07:48]

Patchset 7 (id:??) landed as
https://crrev.com/2636d976fb583560c0817dc258a9e37578501bec
Cr-Commit-Position: refs/heads/master@{#297359}