chrome/browser/ui/app_list/app_list_service_mac.mm - Issue 592983002: Fix Mac App Launcher observer lifetime on AppListItemList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_service_mac.mm

Issue 592983002: Fix Mac App Launcher observer lifetime on AppListItemList (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: leave disabled due to other flakiness Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/app_list/app_list_service_mac.mm

diff --git a/chrome/browser/ui/app_list/app_list_service_mac.mm b/chrome/browser/ui/app_list/app_list_service_mac.mm

index 5f66fbba08a85e7b55ef9f0c490ad629d93398bf..762a571ac060f0133c12e8c5425b1c560a9be0b0 100644

--- a/chrome/browser/ui/app_list/app_list_service_mac.mm

+++ b/chrome/browser/ui/app_list/app_list_service_mac.mm

@@ -392,6 +392,7 @@ void AppListServiceMac::CreateForProfile(Profile* requested_profile) {

if (!window_controller_)

window_controller_.reset([[AppListWindowController alloc] init]);

+ [[window_controller_ appListViewController] setDelegate:nil];

[[window_controller_ appListViewController]

setDelegate:GetViewDelegate(profile_)];

}

« no previous file with comments | « no previous file | ui/app_list/app_list_item_list.cc » ('j') | no next file with comments »