Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1216)

Issue 592863002: Fix mojom dependencies in media/mojo/services, make gn check pass (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix mojom dependencies in media/mojo/services, make gn check pass This fixes the flaky compilation error seen here: http://build.chromium.org/p/chromium.lkgr/builders/Win%20x64/builds/2616/steps/compile/logs/stdio FAILED: ninja -t msvc -e environment.x64 -- "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\media\mojo\services\media_mojo_lib.mojo_renderer_impl.obj.rsp /c ..\..\media\mojo\services\mojo_renderer_impl.cc /Foobj\media\mojo\services\media_mojo_lib.mojo_renderer_impl.obj /Fdobj\media\media_mojo_lib.cc.pdb c:\b\build\slave\win_x64\build\src\mojo\public\cpp\application\connect.h(8) : fatalerror C1083: Cannot open include file: 'mojo/public/interfaces/application/service_provider.mojom.h': No such file or directory ninja: build stopped: subcommand failed. and makes (ToT) gn check media/mojo/services:* pass R=scherkus@chromium.org Committed: https://crrev.com/17a5fbfc0b9dfd6e9f3e7e4e3af7d5484b49728b Cr-Commit-Position: refs/heads/master@{#296084}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M media/BUILD.gn View 2 chunks +5 lines, -2 lines 0 comments Download
M media/media.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M media/mojo/services/BUILD.gn View 2 chunks +5 lines, -1 line 0 comments Download
M mojo/public/interfaces/application/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jamesr
6 years, 3 months ago (2014-09-22 21:25:57 UTC) #2
scherkus (not reviewing)
lgtm
6 years, 3 months ago (2014-09-22 21:27:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592863002/1
6 years, 3 months ago (2014-09-22 21:31:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 210f4c16303f03a64df085c6185c66a61c46de0c
6 years, 3 months ago (2014-09-22 23:08:34 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 23:09:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17a5fbfc0b9dfd6e9f3e7e4e3af7d5484b49728b
Cr-Commit-Position: refs/heads/master@{#296084}

Powered by Google App Engine
This is Rietveld 408576698