Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory/location_manager.dart

Issue 59283007: List scripts in library and display script source (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/observatory/location_manager.dart
diff --git a/runtime/bin/vmservice/client/lib/src/observatory/location_manager.dart b/runtime/bin/vmservice/client/lib/src/observatory/location_manager.dart
index 97df4564e4b687decc8c236b50123fc7430d30bf..b4f487cf6564b521b5a31fcefd0201b4f8cefb3c 100644
--- a/runtime/bin/vmservice/client/lib/src/observatory/location_manager.dart
+++ b/runtime/bin/vmservice/client/lib/src/observatory/location_manager.dart
@@ -16,7 +16,7 @@ class LocationManager extends Observable {
ObservatoryApplication get application => _application;
@observable String currentHash = '';
-
+ @observable Uri currentHashUri;
void init() {
window.onHashChange.listen((event) {
if (setDefaultHash()) {
@@ -48,6 +48,15 @@ class LocationManager extends Observable {
return currentIsolateAnchorPrefix() != null;
}
+ bool get isScriptLink {
+ String type = currentHashUri.queryParameters['type'];
+ return type == 'Script';
+ }
+
+ String get scriptName {
+ return Uri.decodeQueryComponent(currentHashUri.queryParameters['name']);
+ }
+
/// Extract the current isolate id as an integer. Returns [InvalidIsolateId]
/// if none is present in window.location.
int currentIsolateId() {
@@ -76,6 +85,7 @@ class LocationManager extends Observable {
currentHash = window.location.hash;
// Chomp off the #
String requestUrl = currentHash.substring(1);
+ currentHashUri = Uri.parse(requestUrl);
application.requestManager.get(requestUrl);
}
@@ -109,6 +119,16 @@ class LocationManager extends Observable {
return classLink(isolateId, cid);
}
+ /// Create a request for the script [objectId] with script [name].
+ @observable
+ String currentIsolateScriptLink(int objectId, String name) {
+ var isolateId = currentIsolateId();
+ if (isolateId == LocationManager.InvalidIsolateId) {
+ return defaultHash;
+ }
+ return scriptLink(isolateId, objectId, name);
+ }
+
/// Create a request for [l] on [isolateId].
@observable
String relativeLink(int isolateId, String l) {
@@ -126,4 +146,12 @@ class LocationManager extends Observable {
String classLink(int isolateId, int cid) {
return '#/isolates/$isolateId/classes/$cid';
}
+
+ @observable
+ /// Create a request for the script [objectId] with script [url].
+ String scriptLink(int isolateId, int objectId, String name) {
+ String encodedName = Uri.encodeQueryComponent(name);
+ return '#/isolates/$isolateId/objects/$objectId'
+ '?type=Script&name=$encodedName';
+ }
}

Powered by Google App Engine
This is Rietveld 408576698