Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: gm/rebaseline_server/static/loader.js

Issue 59283006: rebaseline_server: add pixel diffs, and sorting by diff metrics (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: rename_selftest Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gm/rebaseline_server/server.py ('k') | gm/rebaseline_server/static/view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/rebaseline_server/static/loader.js
===================================================================
--- gm/rebaseline_server/static/loader.js (revision 12171)
+++ gm/rebaseline_server/static/loader.js (working copy)
@@ -58,7 +58,7 @@
$scope.header = data.header;
$scope.categories = data.categories;
$scope.testData = data.testData;
- $scope.sortColumn = 'test';
+ $scope.sortColumn = 'weightedDiffMeasure';
$scope.showTodos = false;
$scope.showSubmitAdvancedSettings = false;
@@ -242,6 +242,13 @@
// array copies? (For better performance.)
if ($scope.viewingTab == $scope.defaultTab) {
+
+ // TODO(epoger): Until we allow the user to reverse sort order,
+ // there are certain columns we want to sort in a different order.
+ var doReverse = (
+ ($scope.sortColumn == 'percentDifferingPixels') ||
+ ($scope.sortColumn == 'weightedDiffMeasure'));
+
$scope.filteredTestData =
$filter("orderBy")(
$filter("removeHiddenItems")(
@@ -252,7 +259,7 @@
$scope.categoryValueMatch.test,
$scope.viewingTab
),
- $scope.sortColumn);
+ $scope.sortColumn, doReverse);
$scope.limitedTestData = $filter("limitTo")(
$scope.filteredTestData, $scope.displayLimit);
} else {
« no previous file with comments | « gm/rebaseline_server/server.py ('k') | gm/rebaseline_server/static/view.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698