Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: gm/rebaseline_server/server.py

Issue 59283006: rebaseline_server: add pixel diffs, and sorting by diff metrics (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: improve_self_test Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gm/rebaseline_server/server.py
===================================================================
--- gm/rebaseline_server/server.py (revision 12157)
+++ gm/rebaseline_server/server.py (working copy)
@@ -45,6 +45,8 @@
PATHSPLIT_RE = re.compile('/([^/]+)/(.+)')
TRUNK_DIRECTORY = os.path.dirname(os.path.dirname(os.path.dirname(
os.path.realpath(__file__))))
+GENERATED_IMAGES_ROOT = os.path.join(PARENT_DIRECTORY, 'static',
+ 'generated-images')
# A simple dictionary of file name extensions to MIME types. The empty string
# entry is used as the default when no extension was given or if the extension
@@ -155,11 +157,12 @@
expectations_repo.Update('.')
logging.info(
- 'Parsing results from actuals in %s and expectations in %s ...' % (
+ 'Parsing results from actuals in %s and expectations in %s, and generating pixel diffs (may take a while) ...' % (
rmistry 2013/11/06 19:12:52 nit: line > 80
epoger 2013/11/07 21:11:53 Done.
self._actuals_dir, self._expectations_dir))
self.results = results.Results(
actuals_root=self._actuals_dir,
- expected_root=self._expectations_dir)
+ expected_root=self._expectations_dir,
+ generated_images_root=GENERATED_IMAGES_ROOT)
def _result_reloader(self):
""" If --reload argument was specified, reload results at the appropriate

Powered by Google App Engine
This is Rietveld 408576698