Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: Source/bindings/v8/ScriptDebugServer.cpp

Issue 59283004: Workaround for 14802 (Closed) Base URL: svn://svn.chromium.org/multivm/branches/1650/blink
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ScriptDebugServer.cpp
diff --git a/Source/bindings/v8/ScriptDebugServer.cpp b/Source/bindings/v8/ScriptDebugServer.cpp
index 89c9ea7a7946971cbef658513ff0166ce496da6f..2eb227aafc0a6976f415c918ef59137c90ef4e03 100644
--- a/Source/bindings/v8/ScriptDebugServer.cpp
+++ b/Source/bindings/v8/ScriptDebugServer.cpp
@@ -393,6 +393,12 @@ void ScriptDebugServer::handleProgramBreak(v8::Handle<v8::Object> executionState
void ScriptDebugServer::handleProgramBreak(const v8::Debug::EventDetails& eventDetails, v8::Handle<v8::Value> exception, v8::Handle<v8::Array> hitBreakpointNumbers)
{
+ // FIXME(http://dartbug.com/14802): The check in the function above appears to be insufficient as
+ // m_pausedContext is cleared for current invocations of handleProgramBreak.
+ // Don't allow nested breaks.
+ if (isPaused())
+ return;
+
m_pausedContext = eventDetails.GetEventContext();
handleProgramBreak(eventDetails.GetExecutionState(), exception, hitBreakpointNumbers);
m_pausedContext.Clear();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698