Issue 59283003: Reland 232311: Embeds offline voice recognizer plugin and its manager to app-list start page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59283003: Reland 232311: Embeds offline voice recognizer plugin and its manager to app-list start page. (Closed)

Created:
7 years, 1 month ago by Jun Mukai

Modified:
7 years, 1 month ago

Reviewers:
xiyuan

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Reland 232311: Embeds offline voice recognizer plugin and its manager to app-list start page. r232311 was reverted due to a crash bug at shutdown. This is simply a reland because the crash bug has been fixed by r233015. See also crbug.com/314567 BUG=312365, 314567 TBR=xiyuan@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233390

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+625 lines, -1 line)			Patch
A	chrome/browser/resources/app_list/audio_manager.js	View	1 chunk	+123 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/app_list/greconacl.nmf	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/app_list/plugin_manager.js	View	1 chunk	+160 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/app_list/speech_manager.js	View	1 chunk	+152 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/app_list/speech_recognition_manager.js	View	1 chunk	+73 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/app_list/start_page.html	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/app_list/start_page.js	View	3 chunks	+15 lines, -1 line	0 comments	Download
M	chrome/browser/ui/app_list/start_page_service.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/app_list/start_page_service.cc	View	4 chunks	+22 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/app_list/start_page_ui.cc	View	2 chunks	+57 lines, -0 lines	0 comments	Download
M	ui/app_list/views/apps_grid_view.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/59283003/1

7 years, 1 month ago (2013-11-06 18:51:23 UTC) #1

Message was sent while issue was closed.

Change committed as 233390