LayoutTests/fast/css-grid-layout/grid-preferred-logical-widths.html - Issue 592803003: [CSS Grid Layout] Size tracks using a list of all items sorted by span

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-preferred-logical-widths.html

Issue 592803003: [CSS Grid Layout] Size tracks using a list of all items sorted by span (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed reviewer's comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution.html ('K') | « LayoutTests/fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt ('k') | Source/core/rendering/RenderGrid.h » ('j') | Source/core/rendering/RenderGrid.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <link href="resources/grid.css" rel=stylesheet>	4 <link href="resources/grid.css" rel=stylesheet>

5 <link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel =stylesheet>	5 <link href="../css-intrinsic-dimensions/resources/width-keyword-classes.css" rel =stylesheet>

6 <style>	6 <style>

7 .gridMinContentFixed {	7 .gridMinContentFixed {

8 grid-template-columns: minmax(min-content, 40px) minmax(min-content, 40px);	8 grid-template-columns: minmax(min-content, 40px) minmax(min-content, 40px);

9 grid-template-rows: 10px;	9 grid-template-rows: 10px;

10 font: 10px/1 Ahem;	10 font: 10px/1 Ahem;

(...skipping 109 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
120 <div class="firstRowSecondColumn">XXXXX XXXXX</div>	120 <div class="firstRowSecondColumn">XXXXX XXXXX</div>

121 </div>	121 </div>

122 <div class="grid gridFixedMaxContent max-content" data-expected-height="10" data -expected-width="80">	122 <div class="grid gridFixedMaxContent max-content" data-expected-height="10" data -expected-width="80">

123 <div class="firstRowBothColumn">XX XX XX</div>	123 <div class="firstRowBothColumn">XX XX XX</div>

124 <div class="firstRowBothColumn">XX XX XX</div>	124 <div class="firstRowBothColumn">XX XX XX</div>

125 </div>	125 </div>

126 <div class="grid gridAutoContent min-content" data-expected-height="10" data-exp ected-width="20">	126 <div class="grid gridAutoContent min-content" data-expected-height="10" data-exp ected-width="20">

127 <div class="firstRowFirstColumn">XX XX XX</div>	127 <div class="firstRowFirstColumn">XX XX XX</div>

128 <div class="firstRowBothColumn">XX XX XX</div>	128 <div class="firstRowBothColumn">XX XX XX</div>

129 </div>	129 </div>

130 <div class="grid gridAutoContent max-content" data-expected-height="10" data-exp ected-width="120">	130 <div class="grid gridAutoContent max-content" data-expected-height="10" data-exp ected-width="80">

131 <div class="firstRowBothColumn">XX XX XX</div>	131 <div class="firstRowBothColumn">XX XX XX</div>

132 <div class="firstRowSecondColumn">XX XX XX</div>	132 <div class="firstRowSecondColumn">XX XX XX</div>

133 </div>	133 </div>

134	134

135 </body>	135 </body>

136 </html>	136 </html>

OLD	NEW