remoting/webapp/unittests/menu_button_unittest.js - Issue 592793003: Make pop-up menus more easily dismissable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/unittests/menu_button_unittest.js

Issue 592793003: Make pop-up menus more easily dismissable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add click-trap to the container element, not the body Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/webapp/unittests/menu_button_unittest.js

diff --git a/remoting/webapp/unittests/menu_button_unittest.js b/remoting/webapp/unittests/menu_button_unittest.js

index cba90fbc384e502e5bed94dba59ce823d33835bc..48728f8a0f47948e546fcc1f0a756e21273168f0 100644

--- a/remoting/webapp/unittests/menu_button_unittest.js

+++ b/remoting/webapp/unittests/menu_button_unittest.js

@@ -47,15 +47,12 @@ test('should dismiss when <body> is clicked', function() {

ok(menu.offsetWidth == 0 && menu.offsetHeight == 0);

});

-/*

-TODO(jamiewalch): Reinstate this once MenuButton is fixed properly.

test('should dismiss when button is clicked', function() {

var menu = menuButton.menu();

menuButton.button().click();

ok(menu.offsetWidth == 0 && menu.offsetHeight == 0);

});

-*/

test('should dismiss when menu item is clicked', function() {

var menu = menuButton.menu();