Enable virtual keyboard in overview mode

Enable virtual keyboard in overview mode

Touch view uses virtual_keyboard_window_controller to enable/disable
virtual keyboard. However, virtual_keyboard_window_controller is specific
for a Touch Usability mode which nobody uses and is removed. This CL adds a
VirtualKeyboardObserver to replace virtual_keyboard_window_controller.

BUG=416495
Committed: https://crrev.com/eaae09a093fc4c3d4ac8ba0f36e367e8a3dc7378
Cr-Commit-Position: refs/heads/master@{#296086}

[bshe, 2014-09-22 16:11:23]

bshe@chromium.org changed reviewers:
+ oshima@chromium.org

[bshe, 2014-09-22 16:11:24]

Hi Oshima-san.

Do you mind to take a look at this? It looks like touch view uses
virtual_keyboard_window_controller which I removed earlier. I added the logic
back to virtual_keyboard_observer class as I think it doesnt make sense to
create a virtual_keyboard_window_controller again for touch view. Not sure if
this is the best place to put virtual_keyboard_observer though. Do you have any
suggestion?

Thanks!

[oshima, 2014-09-22 18:39:04]

https://codereview.chromium.org/592753004/diff/20001/ash/virtual_keyboard_obs...
File ash/virtual_keyboard_observer.h (right):

https://codereview.chromium.org/592753004/diff/20001/ash/virtual_keyboard_obs...
ash/virtual_keyboard_observer.h:14: class ASH_EXPORT VirtualKeyboardObserver :
public ShellObserver {
I think VirtualKeyboardController is better name because it's controlling VK by
observing touch view mode change. WDYT?

[bshe, 2014-09-22 19:44:31]

Renamed to VirtualKeyboardController. Could you please take another look? Thanks

https://codereview.chromium.org/592753004/diff/20001/ash/virtual_keyboard_obs...
File ash/virtual_keyboard_observer.h (right):

https://codereview.chromium.org/592753004/diff/20001/ash/virtual_keyboard_obs...
ash/virtual_keyboard_observer.h:14: class ASH_EXPORT VirtualKeyboardObserver :
public ShellObserver {
Make sense. Done.

On 2014/09/22 18:39:04, oshima wrote:
> I think VirtualKeyboardController is better name because it's controlling VK
by
> observing touch view mode change. WDYT?

[oshima, 2014-09-22 20:01:59]

lgtm

[bshe, 2014-09-22 22:25:09]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2014-09-22 22:25:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/592753004/40001

[commit-bot: I haz the power, 2014-09-22 23:17:01]

Committed patchset #3 (id:40001) as d92f141f41976a922084102724fd6c6b0c4d1c23

[commit-bot: I haz the power, 2014-09-22 23:17:35]

Patchset 3 (id:??) landed as
https://crrev.com/eaae09a093fc4c3d4ac8ba0f36e367e8a3dc7378
Cr-Commit-Position: refs/heads/master@{#296086}