Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 592753003: Notify RenderView webview() when the device color profile changes (Closed)

Created:
6 years, 3 months ago by Noel Gordon
Modified:
6 years, 2 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dsinclair, jam, Justin Novosad, Ken Russell (switch to Gerrit), mkwst+moarreviews-renderer_chromium.org, nasko+codewatch_chromium.org, Stephen White, sugoi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Notify RenderView webview() when the device color profile changes Notify RenderView webview() when the Page color profile changes so it can update and repaint all color profiled elements on the Page. Not used as yet: the IPC from the browser-side will be added later (need to resolve issue 338130, issue 357443 first), so this change is just more plumbing. CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg BUG=368663 Committed: https://crrev.com/c76aa4c941af97cb60423c412cae7c7a9b2acd74 Cr-Commit-Position: refs/heads/master@{#296605}

Patch Set 1 #

Patch Set 2 : Android stl compile fix. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/renderer/render_view_impl.cc View 1 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 10 (2 generated)
Noel Gordon
6 years, 3 months ago (2014-09-22 15:52:45 UTC) #2
Noel Gordon
+dsinclair who was saying something about removing this layer. It's not just performance, it's the ...
6 years, 3 months ago (2014-09-22 16:16:27 UTC) #3
Noel Gordon
https://codereview.chromium.org/592753003/diff/20001/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/592753003/diff/20001/content/renderer/render_view_impl.cc#newcode3689 content/renderer/render_view_impl.cc:3689: webview()->setDeviceColorProfile(colorProfile); webview()->setDeviceColorProfile(profile); also works, but the data copy is ...
6 years, 3 months ago (2014-09-22 17:15:02 UTC) #4
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-24 19:58:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592753003/20001
6 years, 3 months ago (2014-09-24 23:59:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c4957c72a70417bbd9e444aed31b5a73266a404d
6 years, 3 months ago (2014-09-25 01:09:03 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c76aa4c941af97cb60423c412cae7c7a9b2acd74 Cr-Commit-Position: refs/heads/master@{#296605}
6 years, 3 months ago (2014-09-25 01:09:47 UTC) #9
Noel Gordon
6 years, 2 months ago (2014-09-30 03:52:48 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/592753003/diff/20001/content/renderer/render_...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/592753003/diff/20001/content/renderer/render_...
content/renderer/render_view_impl.cc:3689:
webview()->setDeviceColorProfile(colorProfile);
On 2014/09/22 17:15:02, Noel Gordon wrote:
> webview()->setDeviceColorProfile(profile); also works, but the data copy is
not
> so obvious.

Refer to https://codereview.chromium.org/261633002 to see how this WebVector
gets copied again into WTF::Vector for use inside blink.  Using SharedData<char>
in place of WTF::Vector<char> would save a one copy, but is an unwieldy data
type for the blink sub-system being updated here.

Powered by Google App Engine
This is Rietveld 408576698