Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 592743003: Update CSS3DBlueBox pixel baseline. (Closed)

Created:
6 years, 3 months ago by Jamie Madill
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, Dirk Pranke, boliu
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update CSS3DBlueBox pixel baseline. Recent changes caused the Android Debug GPU bot to fail this test. This could possibly be due to anti-aliasing changes. BUG=416450 Committed: https://crrev.com/6f29d319d8dd43cb66fc56513d1bc701e5ad8ed2 Cr-Commit-Position: refs/heads/master@{#296012}

Patch Set 1 #

Patch Set 2 : Updated expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/gpu/page_sets/pixel_tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Jamie Madill
PTAL. I can't commit manually or TBR.
6 years, 3 months ago (2014-09-22 15:30:14 UTC) #2
Ken Russell (switch to Gerrit)
LGTM
6 years, 3 months ago (2014-09-22 16:35:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592743003/1
6 years, 3 months ago (2014-09-22 16:36:32 UTC) #5
Ken Russell (switch to Gerrit)
I forgot -- the test needs to be marked as failing. Please follow the instructions ...
6 years, 3 months ago (2014-09-22 17:18:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592743003/20001
6 years, 3 months ago (2014-09-22 17:27:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 1cfd3a940e1e8341225c5729ba741e831a05cb4b
6 years, 3 months ago (2014-09-22 18:12:59 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 18:13:41 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f29d319d8dd43cb66fc56513d1bc701e5ad8ed2
Cr-Commit-Position: refs/heads/master@{#296012}

Powered by Google App Engine
This is Rietveld 408576698