Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 592703002: Fix profiler for TurboFan by reducing duplication. (Closed)

Created:
6 years, 3 months ago by Michael Starzinger
Modified:
6 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix profiler for TurboFan by reducing duplication. R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24115

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed comments by Ben Titzer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -134 lines) Patch
M src/compiler.cc View 1 5 chunks +115 lines, -134 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
https://codereview.chromium.org/592703002/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/592703002/diff/1/src/compiler.cc#newcode704 src/compiler.cc:704: MUST_USE_RESULT static MaybeHandle<Code> GetCodeFromOptimizedCodeMap( Note that this entire chunk ...
6 years, 3 months ago (2014-09-22 11:04:16 UTC) #1
titzer
lgtm with comment https://codereview.chromium.org/592703002/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/592703002/diff/1/src/compiler.cc#newcode396 src/compiler.cc:396: (FLAG_turbo_asm && info()->shared_info()->asm_function())) { turbo_asm check ...
6 years, 3 months ago (2014-09-22 11:27:40 UTC) #2
Michael Starzinger
Addressed comments. Landing. https://codereview.chromium.org/592703002/diff/1/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/592703002/diff/1/src/compiler.cc#newcode396 src/compiler.cc:396: (FLAG_turbo_asm && info()->shared_info()->asm_function())) { On 2014/09/22 ...
6 years, 3 months ago (2014-09-22 11:35:37 UTC) #3
Michael Starzinger
6 years, 3 months ago (2014-09-22 12:32:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24115 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698