Chromium Code Reviews
Help | Chromium Project | Sign in
(967)

Issue 5927005: Need to copy cert_verifier_. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by wtc
Modified:
2 years, 11 months ago
Reviewers:
agl
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

The ChromeURLRequestContext(ChromeURLRequestContext* other)
constructor should copy cert_verifier_ and dnsrr_resolver_.

R=agl
BUG=63357
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69563

Patch Set 1 #

Patch Set 2 : Also copy dnsrr_resolver_ #

Patch Set 3 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Lint Patch
M chrome/browser/net/chrome_url_request_context.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 2
wtc
3 years, 4 months ago #1
agl
3 years, 4 months ago #2
LGTM. The comment should probably be TODO(agl)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6