Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(581)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 592683002: Adds conversion rule for WebAXRoleNone (Closed)

Created:
6 years, 3 months ago by shreeramk
Modified:
6 years, 3 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds conversion rule for WebAXRoleNone This is blink side patch for this CL https://codereview.chromium.org/588653003/ BUG=385070 Committed: https://crrev.com/7169b5a973686bac8812930eb9a77462e3069b6d Cr-Commit-Position: refs/heads/master@{#296521}

Patch Set 1 #

Patch Set 2 : Adding Test Case #

Patch Set 3 : Adding expectations for Mac and android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-none.html View 1 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/aria-none-expected-android.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-none-expected-mac.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-none-expected-win.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review! Thanks.
6 years, 3 months ago (2014-09-23 13:19:12 UTC) #2
dmazzoni
lgtm
6 years, 3 months ago (2014-09-24 20:01:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592683002/40001
6 years, 3 months ago (2014-09-24 20:03:25 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 04a4c952742cfebdbc2d4cf6ed061112e6222666
6 years, 3 months ago (2014-09-24 21:23:18 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 21:23:41 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7169b5a973686bac8812930eb9a77462e3069b6d
Cr-Commit-Position: refs/heads/master@{#296521}

Powered by Google App Engine
This is Rietveld 408576698