Issue 59263004: ozone: Fix shared component builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 59263004: ozone: Fix shared component builds. (Closed)

Created:
7 years, 1 month ago by sadrul

Modified:
7 years, 1 month ago

Reviewers:
rjkroege, Peter Mayo

CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -3 lines)			Patch
M	ui/events/ozone/evdev/event_factory.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/gfx/ozone/impl/dri_surface_factory.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/gfx/ozone/impl/file_surface_factory.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Peter Mayo

LGTM - It fixes issue 315319 for 4 unittests. I am not qualified to know ...

7 years, 1 month ago (2013-11-06 02:02:45 UTC) #1

sadrul

7 years, 1 month ago (2013-11-06 16:03:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r233274 (presubmit successful).