Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Unified Diff: third_party/polymer/README.chromium

Issue 592593002: Inline scripts were extracted from Polymer elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: s/echo ""/echo/ Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/polymer/bower.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/polymer/README.chromium
diff --git a/third_party/polymer/README.chromium b/third_party/polymer/README.chromium
index 3490cc3997f18c376a5a37e402bd434744e6d86d..eaba41b14c1ea671771df2448c5126df104b9d21 100644
--- a/third_party/polymer/README.chromium
+++ b/third_party/polymer/README.chromium
@@ -32,9 +32,14 @@ technologies called the Polymer.
Local Modifications:
- Removed executable bit from the files in 'components/core-list'.
+- Created a copy 'components-chromium' of the 'components' directory with the
+only difference that all inline JavaScript blocks are extracted from Polymer
+HTML elements to external JS files. This version of the Polymer is used in a web
+UI, where CSP forbids an execution of inline scripts. The extraction was made
+with the help of the Vulcanize tool (https://github.com/Polymer/vulcanize).
-To restore a content of the 'components' and '../third_party/web-animations-js'
-directory from scratch, run ./reproduce.sh (requires bower).
+To restore a content of the 'components', 'components-chromium' directorires
+from scratch, run ./reproduce.sh (requires bower and vulcanize).
Note on Bower:
The directory can be updated by running "bower update". A new component can be
@@ -45,4 +50,3 @@ Also be sure that you listed all the added packages and **all their
dependencies** in bower.json, and specified **exact** versions of every package
explicitly. That is needed because Bower can't handle recursive dependencies
correctly (see http://stackoverflow.com/q/25899532).
-
« no previous file with comments | « no previous file | third_party/polymer/bower.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698