third_party/polymer/reproduce.sh - Issue 592593002: Inline scripts were extracted from Polymer elements.

Side by Side Diff: third_party/polymer/reproduce.sh

Issue 592593002: Inline scripts were extracted from Polymer elements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 #!/bin/bash	1 #!/bin/bash

2	2

3 # Copyright 2014 The Chromium Authors. All rights reserved.	3 # Copyright 2014 The Chromium Authors. All rights reserved.

4 # Use of this source code is governed by a BSD-style license that can be	4 # Use of this source code is governed by a BSD-style license that can be

5 # found in the LICENSE file.	5 # found in the LICENSE file.

6	6
	raymes 2014/09/23 00:27:56 Please add a comment inside this script and extrac Please add a comment inside this script and extract_inline_scripts.sh saying what they do. Could we call this "modify_components_for_chromium.sh" or something similar? dzhioev (left Google) 2014/09/23 09:48:53 extract_inline_scripts.sh already has a usage mess Show quoted text On 2014/09/23 00:27:56, raymes wrote: > Please add a comment inside this script and extract_inline_scripts.sh saying > what they do. extract_inline_scripts.sh already has a usage message. Added comment in reproduce.sh. Show quoted text >Could we call this "modify_components_for_chromium.sh" or > something similar? I think reproduce.sh is a right name, because a reproducing of the directory content is exactly what the script does.
7 set -e	7 set -e

8	8

9 rm -rf components	9 rm -rf components components-extracted

10 bower install	10 bower install

11 find components/web-animations-js/ -type f \	11 find components/web-animations-js/ -type f \

12 -not \( -name web-animations.js -o \	12 -not \( -name web-animations.js -o \

13 -name README.md -o \	13 -name README.md -o \

14 -name COPYING \) -delete	14 -name COPYING \) -delete

15 find components/web-animations-js/ -type d -empty -delete	15 find components/web-animations-js/ -type d -empty -delete

16 find components/core-list -type f -exec chmod -x {} \;	16 find components/core-list -type f -exec chmod -x {} \;
	raymes 2014/09/23 00:27:56 rather than modifying web-animations-js inside com rather than modifying web-animations-js inside components/ why not modify the version inside components-extracted/? Then all of our local modifications are in components-extracted/. You could even change the name of components-extracted/ to be components-chromium. WDYT? raymes 2014/09/23 00:48:10 Oh I see the reason now, because we don't want tho Oh I see the reason now, because we don't want those files in the source tree at all. We can't do this then :( dzhioev (left Google) 2014/09/23 09:48:53 Renamed components-extracted to components-chromiu Show quoted text On 2014/09/23 00:27:56, raymes wrote: > rather than modifying web-animations-js inside components/ why not modify the > version inside components-extracted/? Then all of our local modifications are in > components-extracted/. You could even change the name of components-extracted/ > to be components-chromium. WDYT? Renamed components-extracted to components-chromium dzhioev (left Google) 2014/09/23 09:48:54 Yep Show quoted text On 2014/09/23 00:48:10, raymes wrote: > Oh I see the reason now, because we don't want those files in the source tree at > all. We can't do this then :( Yep
	17 ./extract_inline_scripts.sh
	raymes 2014/09/23 00:27:56 Would we only every likely call this from here? Sh Would we only every likely call this from here? Should we just inline it? If there is a good reason to keep it separate that's ok too. dzhioev (left Google) 2014/09/23 09:48:53 It's pretty large, so I think it's good idea to ke Show quoted text On 2014/09/23 00:27:56, raymes wrote: > Would we only every likely call this from here? Should we just inline it? If > there is a good reason to keep it separate that's ok too. It's pretty large, so I think it's good idea to keep it in a separate file.
OLD	NEW

« third_party/polymer/extract_inline_scripts.sh ('K') | « third_party/polymer/extract_inline_scripts.sh ('k') | third_party/polymer/vulcanize_config.json » ('j') | no next file with comments »