Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 592423005: Supervised user blacklist: Add downloader class to download a blacklist if needed. (Closed)

Created:
6 years, 2 months ago by Marc Treib
Modified:
6 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Supervised user blacklist: Add downloader class to download a blacklist if needed. BUG=410824 Committed: https://crrev.com/f136dfbfed04de5cc9dd751cd7836bbbd0bcd3fd Cr-Commit-Position: refs/heads/master@{#296735}

Patch Set 1 #

Patch Set 2 : include cleanup #

Total comments: 2

Patch Set 3 : review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -3 lines) Patch
A chrome/browser/supervised_user/experimental/supervised_user_blacklist_downloader.h View 1 1 chunk +55 lines, -0 lines 0 comments Download
A chrome/browser/supervised_user/experimental/supervised_user_blacklist_downloader.cc View 1 2 1 chunk +79 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.h View 4 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 3 chunks +29 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Marc Treib
PTAL!
6 years, 2 months ago (2014-09-25 12:32:54 UTC) #2
Bernhard Bauer
https://codereview.chromium.org/592423005/diff/20001/chrome/browser/supervised_user/experimental/supervised_user_blacklist_downloader.cc File chrome/browser/supervised_user/experimental/supervised_user_blacklist_downloader.cc (right): https://codereview.chromium.org/592423005/diff/20001/chrome/browser/supervised_user/experimental/supervised_user_blacklist_downloader.cc#newcode28 chrome/browser/supervised_user/experimental/supervised_user_blacklist_downloader.cc:28: fetcher_.reset(URLFetcher::Create(url, URLFetcher::GET, this)); You could initialize the fetcher_ in ...
6 years, 2 months ago (2014-09-25 15:47:39 UTC) #3
Marc Treib
https://codereview.chromium.org/592423005/diff/20001/chrome/browser/supervised_user/experimental/supervised_user_blacklist_downloader.cc File chrome/browser/supervised_user/experimental/supervised_user_blacklist_downloader.cc (right): https://codereview.chromium.org/592423005/diff/20001/chrome/browser/supervised_user/experimental/supervised_user_blacklist_downloader.cc#newcode28 chrome/browser/supervised_user/experimental/supervised_user_blacklist_downloader.cc:28: fetcher_.reset(URLFetcher::Create(url, URLFetcher::GET, this)); On 2014/09/25 15:47:38, Bernhard Bauer wrote: ...
6 years, 2 months ago (2014-09-25 16:12:21 UTC) #4
Bernhard Bauer
lgtm
6 years, 2 months ago (2014-09-25 16:14:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592423005/40001
6 years, 2 months ago (2014-09-25 16:17:09 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 008414d610587a876483271929648ddab5022f04
6 years, 2 months ago (2014-09-25 17:38:08 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 17:38:48 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f136dfbfed04de5cc9dd751cd7836bbbd0bcd3fd
Cr-Commit-Position: refs/heads/master@{#296735}

Powered by Google App Engine
This is Rietveld 408576698