Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Issue 592413002: WebViewTest.Shim_TestGetProcessId does not need a test server (Closed)

Created:
6 years, 3 months ago by Fady Samuel
Modified:
6 years, 3 months ago
Reviewers:
Xi Han
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

WebViewTest.Shim_TestGetProcessId does not need a test server BUG=none Committed: https://crrev.com/34994f79ede38883d60ff954cbcacb645c60f55f Cr-Commit-Position: refs/heads/master@{#296197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/apps/web_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Fady Samuel
6 years, 3 months ago (2014-09-23 15:41:48 UTC) #2
Xi Han
lgtm
6 years, 3 months ago (2014-09-23 15:45:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592413002/1
6 years, 3 months ago (2014-09-23 15:46:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 039bfba5c70d489f7d3f936f38d6d98c473757fe
6 years, 3 months ago (2014-09-23 16:25:50 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 16:26:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34994f79ede38883d60ff954cbcacb645c60f55f
Cr-Commit-Position: refs/heads/master@{#296197}

Powered by Google App Engine
This is Rietveld 408576698