Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 592353004: img tag should have xml-role as img. (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

img tag should have xml-role as img. According to specs img tag should have xml-role as img. BUG=417230 Committed: https://crrev.com/3f09a820f0e1c6e8a6774bfdcb46d5810e07c2ab Cr-Commit-Position: refs/heads/master@{#296910}

Patch Set 1 #

Patch Set 2 : Adding Accessibility test for img #

Patch Set 3 : #

Patch Set 4 : Adding expectations for mac and android #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/img.html View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/img-expected-android.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/img-expected-mac.txt View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/img-expected-win.txt View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review. Thanks!
6 years, 2 months ago (2014-09-26 06:45:03 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-09-26 08:17:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592353004/80001
6 years, 2 months ago (2014-09-26 08:18:12 UTC) #5
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 2f3929353ac8158d4c280790e631d3fd0f02d51c
6 years, 2 months ago (2014-09-26 09:34:19 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 09:34:52 UTC) #7
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/3f09a820f0e1c6e8a6774bfdcb46d5810e07c2ab
Cr-Commit-Position: refs/heads/master@{#296910}

Powered by Google App Engine
This is Rietveld 408576698