Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issue 592343002: Fixed clang/win build issues. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed clang/win build issues. BUG=416747 Committed: https://crrev.com/54be12874f8ffe516964cbc6d834d483a0e58998 Cr-Commit-Position: refs/heads/master@{#296229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M chrome/browser/printing/pdf_to_emf_converter.cc View 6 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-09-23 07:48:04 UTC) #2
Nico
lgtm (Note: You sent this to thakis@chomium.org, no 'r' in 'chomium', so I didn't get ...
6 years, 3 months ago (2014-09-23 16:49:13 UTC) #4
Vitaly Buka (NO REVIEWS)
On 2014/09/23 16:49:13, Nico (hiding) wrote: > lgtm > > (Note: You sent this to ...
6 years, 3 months ago (2014-09-23 17:25:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/592343002/1
6 years, 3 months ago (2014-09-23 17:59:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as ac3a7a7175fc0d29f87ef9bcba63d37f0ae9c636
6 years, 3 months ago (2014-09-23 20:53:30 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 20:54:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54be12874f8ffe516964cbc6d834d483a0e58998
Cr-Commit-Position: refs/heads/master@{#296229}

Powered by Google App Engine
This is Rietveld 408576698