scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_release.json - Issue 59233015: Make gyp target_arch setting native to chromium/config.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_release.json

Issue 59233015: Make gyp target_arch setting native to chromium/config.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: rebase again Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/chromium/config.py ('K') | « scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_debug_git.json ('k') | scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_release_git.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_release.json

diff --git a/scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_release.json b/scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_release.json

index 5d1c924a8bf61e8e682df96adc62272e6dce63c0..aeaf6d5edcae6870fc7453b472171227b5e6e55b 100644

--- a/scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_release.json

+++ b/scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_release.json

@@ -103,7 +103,7 @@

"runhooks"

"env": {

- "GYP_DEFINES": "component=static_library dcheck_always_on=1 fastbuild=1",

+ "GYP_DEFINES": "component=static_library dcheck_always_on=1 fastbuild=1 target_arch=x64",

"GYP_GENERATORS": "ninja"

"name": "gclient runhooks"

@@ -327,7 +327,7 @@

"runhooks"

"env": {

- "GYP_DEFINES": "component=static_library dcheck_always_on=1 fastbuild=1",

+ "GYP_DEFINES": "component=static_library dcheck_always_on=1 fastbuild=1 target_arch=x64",

"GYP_GENERATORS": "ninja"

"name": "gclient runhooks (2)"