Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 59233014: Setting HTMLMediaElement.controller does not properly remove the 'mediagroup' content attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase on master Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLMediaElement.h
diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h
index 6f0f83019dfb79df2273087aa2aa934d7284622c..e5f0ce60badccc8e35eb045f0ef498ce29bdb197 100644
--- a/Source/core/html/HTMLMediaElement.h
+++ b/Source/core/html/HTMLMediaElement.h
@@ -276,11 +276,8 @@ public:
enum InvalidURLAction { DoNothing, Complain };
bool isSafeToLoadURL(const KURL&, InvalidURLAction);
- const String& mediaGroup() const;
- void setMediaGroup(const String&);
-
MediaController* controller() const;
- void setController(PassRefPtr<MediaController>);
+ void setController(PassRefPtr<MediaController>); // Resets the MediaGroup and sets the MediaController.
protected:
HTMLMediaElement(const QualifiedName&, Document&, bool);
@@ -299,6 +296,8 @@ protected:
virtual bool isMediaElement() const OVERRIDE { return true; }
+ void setControllerInternal(PassRefPtr<MediaController>);
+
// Restrictions to change default behaviors.
enum BehaviorRestrictionFlags {
NoRestrictions = 0,
@@ -452,6 +451,8 @@ private:
void removeBehaviorsRestrictionsAfterFirstUserGesture();
+ const AtomicString& mediaGroup() const;
+ void setMediaGroup(const AtomicString&);
void updateMediaController();
bool isBlocked() const;
bool isBlockedOnMediaController() const;
@@ -559,7 +560,6 @@ private:
MediaElementAudioSourceNode* m_audioSourceNode;
#endif
- String m_mediaGroup;
friend class MediaController;
RefPtr<MediaController> m_mediaController;
« no previous file with comments | « Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698