LayoutTests/media/media-controller.html - Issue 59233014: Setting HTMLMediaElement.controller does not properly remove the 'mediagroup' content attribute

Side by Side Diff: LayoutTests/media/media-controller.html

Issue 59233014: Setting HTMLMediaElement.controller does not properly remove the 'mediagroup' content attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix bug found by Philipj Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src=media-file.js></script>	4 <script src=media-file.js></script>

5 <script src=video-test.js></script>	5 <script src=video-test.js></script>

6	6

7 <script>	7 <script>

8 var controller;	8 var controller;

9 var video2;	9 var video2;

10	10

(...skipping 13 matching lines...) Expand all Loading...
24 consoleWrite("Test that setting mediaGroup to an empty string remove s the controller:")	24 consoleWrite("Test that setting mediaGroup to an empty string remove s the controller:")

25 run("video.mediaGroup = ''");	25 run("video.mediaGroup = ''");

26 testExpected("video.controller", null);	26 testExpected("video.controller", null);

27 consoleWrite("");	27 consoleWrite("");

28 consoleWrite("Test manually creating and assigning a controller to a media element:")	28 consoleWrite("Test manually creating and assigning a controller to a media element:")

29 run("controller = new MediaController()");	29 run("controller = new MediaController()");

30 run("video.controller = controller");	30 run("video.controller = controller");

31 testExpected("video.controller", controller);	31 testExpected("video.controller", controller);

32 consoleWrite("");	32 consoleWrite("");

33 consoleWrite("Test assigning the wrong type to the controller attrib ute of a media element:")	33 consoleWrite("Test assigning the wrong type to the controller attrib ute of a media element:")

34 testException("video.controller = 42", '"TypeError: Value is not of type MediaController"');	34 testException("video.controller = 42", '"TypeError: Failed to set th e \'controller\' property on \'HTMLMediaElement\': The provided value is not of type \'MediaController\'."');

35 testExpected("video.controller", controller);	35 testExpected("video.controller", controller);

36 consoleWrite("");	36 consoleWrite("");

37 consoleWrite("Test assigning a null controller to a media element:")	37 consoleWrite("Test assigning a null controller to a media element:")

38 run("video.controller = null");	38 run("video.controller = null");

39 testExpected("video.controller", null);	39 testExpected("video.controller", null);

40 consoleWrite("");	40 consoleWrite("");

41 consoleWrite("Test that two media elements with the same mediaGroup have the same controller:")	41 consoleWrite("Test that two media elements with the same mediaGroup have the same controller:")

42 run("video.mediaGroup = 'group'");	42 run("video.mediaGroup = 'group'");

43 run("video2.mediaGroup = 'group'");	43 run("video2.mediaGroup = 'group'");

44 testExpected("video.controller === video2.controller", true);	44 testExpected("video.controller === video2.controller", true);

	45 consoleWrite("");

	46 consoleWrite("Test that setting the controller clears the mediaGroup :")

	47 testExpected("video.mediaGroup", "group");

	48 run("video.controller = null");

	49 testExpected("video.controller", null);

	50 testExpected("video.mediaGroup", "");
	philipj_slow 2013/11/08 19:58:04 Also checking !video.hasAttribute('mediagroup') he Also checking !video.hasAttribute('mediagroup') here and below would be good, since I think this would also pass if the attribute was present but empty. Inactive 2013/11/08 20:12:06 Done. Show quoted text On 2013/11/08 19:58:04, philipj wrote: > Also checking !video.hasAttribute('mediagroup') here and below would be good, > since I think this would also pass if the attribute was present but empty. Done.
	51 run("video.mediaGroup = 'group'");

	52 testExpected("video.mediaGroup", "group");

	53 run("video.controller = controller");

	54 testExpected("video.controller", controller);

	55 testExpected("video.mediaGroup", "");

	56 consoleWrite("");

	57 consoleWrite("Test that setting the controller to undefined is treat ed as null:")

	58 testExpected("video.controller", null, "!=");

	59 run("video.controller = undefined");

	60 testExpected("video.controller", null);

45 endTest();	61 endTest();

46 }	62 }

47 </script>	63 </script>

48 </head>	64 </head>

49 <body onload="start()">	65 <body onload="start()">

50 <video></video>	66 <video></video>

51 <video mediagroup="group"></video>	67 <video mediagroup="group"></video>

52 </body>	68 </body>

53 </html>	69 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/media/media-controller-expected.txt » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')