Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp - Issue 59233014: Setting HTMLMediaElement.controller does not properly remove the 'mediagroup' content attribute

Side by Side Diff: Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp

Issue 59233014: Setting HTMLMediaElement.controller does not properly remove the 'mediagroup' content attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
	(Empty)
1 /*

2 * Copyright (C) 2011 Apple Inc. All Rights Reserved.

3 *

4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions

6 * are met:

7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the

11 * documentation and/or other materials provided with the distribution.

12 *

13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY

14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE

15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR

16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR

17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,

18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,

19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR

20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY

21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

24 */

25

26 #include "config.h"

27 #include "V8HTMLMediaElement.h"

28

29 #include "V8MediaController.h"

30

31 namespace WebCore {

32

33 void V8HTMLMediaElement::controllerAttributeSetterCustom(v8::Local<v8::Value> va lue, const v8::PropertyCallbackInfo<void>& info)

34 {

35 MediaController* controller = 0;

36 if (!value->IsNull()) {
haraken 2013/11/07 23:31:35 Won't this CL change existing behavior when undefi Won't this CL change existing behavior when undefined is passed to \|value\|? Could you add a test case of \|value\|=undefined? Inactive 2013/11/08 15:35:38 Yes, you are right that the generated handles unde Show quoted text On 2013/11/07 23:31:35, haraken wrote: > > Won't this CL change existing behavior when undefined is passed to \|value\|? > > Could you add a test case of \|value\|=undefined? Yes, you are right that the generated handles undefined differently than the custom one. We used to throw when given undefined and now we treat it as null. The compatibility risk is low but you are right that it should be highlighted in the Changelog and covered by layout test.
37 if (!V8MediaController::HasInstance(value, info.GetIsolate(), worldType( info.GetIsolate()))) {

38 throwTypeError("Value is not of type MediaController", info.GetIsola te());

39 return;

40 }

41 controller = V8MediaController::toNative(value->ToObject());

42 }

43

44 // 4.8.10.11.2 Media controllers: controller attribute.

45 // On setting, it must first remove the element's mediagroup attribute, if a ny,

46 HTMLMediaElement* imp = V8HTMLMediaElement::toNative(info.Holder());

47 imp->setMediaGroup(String());

48 // and then set the current media controller to the given value.

49 imp->setController(controller);

50 }

51

52 }

OLD	NEW

« no previous file with comments | « Source/bindings/bindings.gypi ('k') | Source/core/html/HTMLMediaElement.h » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')