Issue 592313002: history: reverse overlay buttons (they were previously incorrect).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 592313002: history: reverse overlay buttons (they were previously incorrect). (Closed)

Created:
6 years, 2 months ago by Dan Beam

Modified:
6 years, 2 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@history-focus-test

Project:
chromium

Visibility:
Public.

history: reverse overlay buttons (they were previously incorrect). R=estade@chromium.org BUG=none TEST=browser_tests

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -6 lines)			Patch
M	chrome/browser/resources/history/alert_overlay.html	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/history/history.js	View	1	3 chunks	+12 lines, -3 lines	0 comments	Download
M	chrome/test/data/webui/history_browsertest.js	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download
M	ui/webui/resources/js/cr/ui/overlay.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Dan Beam

6 years, 2 months ago (2014-09-23 21:00:41 UTC) #3

Message was sent while issue was closed.

closing and folding this into https://codereview.chromium.org/591353002/